Skip to content

MagTag Weather fixes for open-meteo update #2914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 18, 2024

Conversation

caternuson
Copy link
Contributor

Some updates and fixes for the recently added open-meteo version of the MagTag Weather code.
https://learn.adafruit.com/magtag-weather

  • Updates the weather_bg.bmp to correct version. Somehow old version was being used.
  • Removes the dependency on NTP for getting local time. Now using time info from API request response header. NTP use was proving to be unstable.
  • Add optional CITY label that can be used in addition to lat/lon for showing location.
  • Thanks to @wavesailor for finding these issues and suggesting updates on discord.

@TheKitty
Copy link
Collaborator

image

@caternuson
Copy link
Contributor Author

pylint: MagTag/MagTag_Weather/openmeteo/code.py:310: Final newline missing (missing-final-newline)
me: ok, i'll add a final newline for you
pylint: MagTag/MagTag_Weather/openmeteo/code.py:311: Trailing newlines (trailing-newlines)
me: (╯°□°)╯︵ ┻━┻

@caternuson caternuson merged commit d7b50d4 into adafruit:main Oct 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants