MCP32xx (12 bit) ADC support and optional baudrate parameter for SPI comms #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 2, 2024 23:54
Three new sub-classes, read method now appears in all sub-classes, constructor only in parent. AnalogIn.value uses calculated shift values based on new class variable BITS. adafruit#41
|
There's also a 13bit MCP33xx series... |
FoamyGuy
reviewed
Oct 7, 2024
There was a problem hiding this comment.
Thanks for working on this @kevinjwalters!
The changes look good to me. Though I will say I don't have any experience with these MCP3XXX devices and not much with ADCs more generally.
I don't have the hardware to test with.
As far as I can tell this is the main product that this library supported: https://www.adafruit.com/product/856 It's listed as out of stock now, but if anyone has access to one and is willing to test out this branch with it to ensure backwards compatibility please let us know how it goes if so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the MCP3202, MCP3204, MCP3208. I've been testing a lot on an MCP3208. #41
I've changed code a bit for MCP30xx but do not own one so have not tested that.
Added
baudrateas a new optional parameter retaining the original 100kHz default. #46