-
Notifications
You must be signed in to change notification settings - Fork 1
Lumen refactoring #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Dear @Perro2110, can you update the |
Good evening everyone! |
SoleBase = "0.11 - 0.13"
I cant see the error as the log is too long and I'm on my mobile. Can you link to the specific log line? |
On another note could the log be made shorter? I think it's full of debug info that can be hidden for clarity |
I'm not sure if you want this but in case I'll forward it to you:
and:
in FreeBsd JULIA_VERSION:1.9
various dependencies like:
and then:
|
…Models.jl into lumen-refactoring
parsebaseformula is an obsolete function. Pushed a fix for this error. |
src/SoleModels.jl
Outdated
@@ -93,7 +93,7 @@ export subtreeheight | |||
include("symbolic-utils.jl") | |||
|
|||
export PlainRuleExtractor | |||
export extractrules, listrules, joinrules | |||
export modalextractrules, listrules, joinrules |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to stress the fact that I'm not bothered by the function being called "modalextractrules". But we need to be able to call it "extractrules". So again my suggestion is on of the following:
- rename the function into "extractrules", and then put a "const modalextractrules = extractrules; export modalextractrules" in a deprecate.jl file
- keep the name "modalextractrules", but also put a "const extractrules = modalextractrules; export xtractrules" in a deprecate.jl file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I fully agree, I chose the first option: rename the function into "extractrules", and then put a "const modalextractrules = extractrules; export modalextractrules" in a deprecate.jl file
I accidentally closed the pr, as I have deleted the dev branch (this was in the plans). Let's see if we can make this merge into main. |
Okay should be good to remove dev now |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
==========================================
+ Coverage 50.91% 56.03% +5.11%
==========================================
Files 16 21 +5
Lines 927 1260 +333
==========================================
+ Hits 472 706 +234
- Misses 455 554 +99 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Now everything is working, test passed both local than on codecov.
|
Ready to merge on branch Main and register a new version. |
For possible registration of SolePostHoc.