Skip to content

Fix insertions in table mri_violations_log #1291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025

Conversation

nicolasbrossard
Copy link
Collaborator

When one of the protocol checks fails, the MRI pipeline attempts to save a record in table mri_violations_log but an error message is printed saying that column CandID does not exist (the dreaded candidate ID refactoring...) This PR updates the MySQL insertion statement so that it uses CandidateID instead of CandID when inserting in mri_violations_log.

@nicolasbrossard nicolasbrossard requested a review from cmadjar May 27, 2025 11:53
@nicolasbrossard nicolasbrossard added Perl imaging pipeline Difficulty: Simple PR or issue that should be easy to implement, review, or test 27.0-bug labels May 27, 2025
Copy link
Collaborator

@cmadjar cmadjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@cmadjar cmadjar merged commit ee115f1 into aces:main May 27, 2025
9 checks passed
@cmadjar cmadjar added this to the 27.0 milestone May 27, 2025
MaximeBICMTL pushed a commit to maximemulder/Loris-MRI that referenced this pull request Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
27.0-bug Difficulty: Simple PR or issue that should be easy to implement, review, or test Perl imaging pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants