Add integration tests for mass_nifti_pic.py #1274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmadjar
added
Blocked
cmadjar
commented
Apr 17, 2025
cmadjar
commented
Apr 17, 2025
maximemulder
requested changes
Apr 18, 2025
There was a problem hiding this comment.
The tests look good but I am not sure if we should be using hard-coded IDs in them.
If you think that's fine, then I am ok with it, if you also prefer to not use hard-coded IDs, you can query the files by path, and then use file.id in the tests.
The only hard requirement to merge the PR is rename or delete parameter_file.py, for the rest do what you like.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds integration tests for the
mass_nifti_pic.pyscript.That exercise revealed a few error messages from
mass_nifti_pic.pythat were incorrect or in the wrong order so correcting them at the same time.