Skip to content

ORM improvements again #1271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 17, 2025
Merged

ORM improvements again #1271

merged 2 commits into from
Apr 17, 2025

Conversation

maximemulder
Copy link
Contributor

@maximemulder maximemulder commented Apr 15, 2025 •
edited
Loading

Changes:

  • Rename DbFile.file_name to DbFile.rel_path
  • Rename DbParameterFile to DbFileParameter
  • Remove some unnecessary None-checks and str() in tests.

@maximemulder maximemulder requested a review from cmadjar April 15, 2025 02:56
@maximemulder maximemulder added Area: CI PR or issue related to continuous integration, including automated tests and static checks Area: ORM PR or issue related to the SQLAlchemy integration Difficulty: Simple PR or issue that should be easy to implement, review, or test labels Apr 15, 2025
@cmadjar cmadjar merged commit 54ce103 into aces:main Apr 17, 2025
9 checks passed
@cmadjar cmadjar modified the milestones: 27, 20.0 (previously called 19.2), 27.0 Apr 17, 2025
@maximemulder maximemulder deleted the improve_orm_again branch April 18, 2025 08:52
@cmadjar cmadjar added this to the 27.0 milestone Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmadjar cmadjar cmadjar approved these changes

Assignees
No one assigned
Labels
Area: CI PR or issue related to continuous integration, including automated tests and static checks Area: ORM PR or issue related to the SQLAlchemy integration Difficulty: Simple PR or issue that should be easy to implement, review, or test
Projects
None yet
Milestone
27.0
Development

Successfully merging this pull request may close these issues.
2 participants
@maximemulder @cmadjar