Adopt new DICOM study importer in the MRI pipeline #1264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximemulder
added
the
Difficulty: Simple
|
@maximemulder could you add this to the LORIS-MRI agenda to make sure everyone is onboard with changing this? I am definitely ok with it but I'd like to be sure it would be ok for CCNA and IBIS or any other projects. |
|
@cmadjar I made the DICOM study importer a configuration option, added a depreciation warning, and made an SQL patch in LORIS#9749. Hide whitespace changes for easier review since my autotrimmer removed some. |
cmadjar
requested changes
Apr 14, 2025
There was a problem hiding this comment.
@maximemulder Could you run the following script to update the perdoc MD files?
mass_perldoc_md_creation.pl -profile prod
|
@cmadjar Updated ! It generated more than I thought because of whitespace difference but taking that into account, the result is pretty much what was expected. |
cmadjar
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title. Replace the uses of
dicomTar.plbyimport_dicom_study.pyin the LORIS MRI pipeline. I would prefer to have this merged for LORIS-MRI 27, but if someone has problems with it 28 is ok too.Succesfully tested on my local LORIS VM.