Automated tests for run_nifti_insertion.py

[cmadjar]

Description

Tests implemented:

• test invalid argument
• test missing NIfTI path argument
• test invalid NIfTI path
• test missing upload ID or tarchive path argument
• test missing JSON path argument
• test incorrect JSON path
• test invalid upload ID
• test invalid tarchive path
• test upload ID and tarchive path argument (only one should be provided)
• test insertion of a NIfTI file with a different patient name than the one stored in the DICOMs
• test insertion of a NIfTI file already uploaded
• test insertion of a NIfTI file that unknown protocol (insertion in mri_protocol_violated_scans)
• test insertion of a NIfTI file with a warning violation (insertion in files and mri_violations_log tables)

Left to be implemented in a separate PR:
everything that is not checked yet in #1256

[maximemulder]

Thanks for the PR ! I just have a few comments:

1. The tests look good, but I would use assert to handle None values instead of str-ing things.
2. Some type errors in the model relationships.
3. Some naming preferences I have in the models.

So lots of small nits, but still, nice job overall ! Some stuff that I only have a weak opinion on is marked "Optional" if you prefer to ignore it.

[maximemulder]

Hhhhhhmmmm, I guess considering you have some previous tests assert file.path == f'blablabla' (that I missed whoopsie), you can indeed put the str() back and merge, thanks for the quick reaction !