(preliminary to SQLAlchemy) Rename database.py
#1151
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximemulder
force-pushed
the
2024-08-13_move-database-to-dataclass
branch
from
d7ff415 to
42aca33
Compare
|
I don't know why there are whitespace changes although I did rebase on |
This was referenced Aug 20, 2024
|
Closed since SQLAlchemy will use the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to use the
lib.databasenamespace for the upcoming SQLAlchemy PR proposal. Thus, I propose movinglib/database.pytolib/database_lib/__init__.py(but any other name is fine with me) to free the namespace. This is done in a separate PR for better separation and ease of review.IMO,
database_libshould be depreciated and eventually replaced by SQLAlchemy in the medium to long term. Given the size of the codebase, I do not expect this migration to be long, and can even do it myself if wanted !