Update Python installation #1145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok I thought the PR was done, but then I made changes, but now I think it is done for real. |
cmadjar
approved these changes
Aug 1, 2024
cmadjar
added
Python imaging pipeline
Area: BIDS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1117 (comment), I believe we should update our Python installation. This PR does that, with a few other improvements to our Python environment.
The Python version used in this PR is Python 3.11, which is a relatively recent stable Python version and is likely the best target imo:
More precisely, I did not reinstall a full LORIS-MRI instance during my testing, but I did test the PR changes on my Ubuntu 22 dev VM and Debian 12, by doing the following :
Another change made in this PR is that it installs a fixed Python version, which is not the case in our current setup (for instance, I had Python 3.10 installed on my dev VM although we use 3.8 in our testing).
I advise to ignore whitespace for reviewing (trailing spaces removed with autoformatting).
Caveat for existing projects
Need to upgrade python to 3.11 or 3.12 when upgrading LORIS-MRI