Add pkg-config support to cmake #121
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maehne
reviewed
Jun 2, 2025
pkg-config pc file is essential for distributions. It was provided by autotools based builds but never supported properly by cmake builds.
maehne
reviewed
Jun 3, 2025
Comment on lines
+725
to
+739
| # Set compilation and linking flags for SystemC | ||
| set(PKGCONFIG_CFLAGS "") | ||
| set(PKGCONFIG_DEFINES "") | ||
| set(PKGCONFIG_LDPRIV "") | ||
|
|
||
| if(ENABLE_PTHREADS) | ||
| get_target_property(pthread_cflags Threads::Threads INTERFACE_COMPILE_OPTIONS) | ||
| if(pthread_cflags) | ||
| set(PKGCONFIG_CFLAGS ${PKGCONFIG_CFLAGS} ${pthread_cflags}) | ||
| endif() | ||
| get_target_property(pthread_lib Threads::Threads INTERFACE_LINK_LIBRARIES) | ||
| if(pthread_lib) | ||
| set(PKGCONFIG_LDPRIV ${PKGCONFIG_LDPRIV} ${pthread_lib}) | ||
| endif() | ||
| endif() |
There was a problem hiding this comment.
I think it is better to query the target properties directly on the SystemC::systemc library to set PKGCONFIG_CFLAGS, PKGCONFIG_DEFINES, and PKGCONFIG_LDPRIV. This should ensure consistency in all cases. It should also take care on the potential transitive dependency on Pthreads.
There was a problem hiding this comment.
Sorry, I attempted to implement that and found it is not possible as SystemC::systemc contains expressions that are only evaluated at GENERATE phase while configuration is done at an earlier phase.
I checked other projects, and it seems like they are all hard-coding flags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkg-config pc file is essential for distributions. It was provided by autotools based builds but never supported properly by cmake builds.