Skip to content

Conversation

@arvindh123
Copy link
Contributor

What type of PR is this?

What does this do?

Which issue(s) does this PR fix/relate to?

  • Related Issue #
  • Resolves #

Have you included tests for your changes?

Did you document any new/modified feature?

Notes

Signed-off-by: Arvindh <arvindh91@gmail.com>
@arvindh123 arvindh123 requested a review from a team as a code owner October 9, 2025 09:00
@codecov
Copy link

codecov bot commented Oct 9, 2025

Codecov Report

❌ Patch coverage is 70.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 34.23%. Comparing base (b0e9e43) to head (2b608bb).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
channels/service.go 0.00% 2 Missing and 1 partial ⚠️
domains/service.go 0.00% 2 Missing and 1 partial ⚠️
domains/postgres/domains.go 71.42% 2 Missing ⚠️
channels/postgres/channels.go 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3180      +/-   ##
==========================================
- Coverage   35.41%   34.23%   -1.19%     
==========================================
  Files         307       56     -251     
  Lines       46774    14934   -31840     
==========================================
- Hits        16567     5113   -11454     
+ Misses      29376     9532   -19844     
+ Partials      831      289     -542     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Arvindh <arvindh91@gmail.com>
dborovcanin
dborovcanin previously approved these changes Oct 9, 2025
@dborovcanin
Copy link
Collaborator

@arvindh123 Please fix the CI.

Signed-off-by: Arvindh <arvindh91@gmail.com>
@dborovcanin dborovcanin merged commit 6f40c7f into absmach:main Oct 9, 2025
7 of 9 checks passed
@dborovcanin dborovcanin deleted the domain-channel-route-error branch October 9, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants