Skip to content

Conversation

@felixgateru
Copy link
Contributor

@felixgateru felixgateru commented Oct 8, 2025

What type of PR is this?

This is a bug fix becaue it fixes the following issue: #3175

What does this do?

This pr fixes domain update endpoint logic to prevent clearing metadata on name or tags update.

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Yes, tests have been updated.

Did you document any new/modified feature?

No

Notes

Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
@codecov
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 27.02%. Comparing base (8d1c3c4) to head (0cdd9fe).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3176      +/-   ##
==========================================
- Coverage   35.39%   27.02%   -8.38%     
==========================================
  Files         307       35     -272     
  Lines       46759    11047   -35712     
==========================================
- Hits        16551     2985   -13566     
+ Misses      29376     7882   -21494     
+ Partials      832      180     -652     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@felixgateru felixgateru marked this pull request as ready for review October 8, 2025 14:46
@felixgateru felixgateru requested a review from a team as a code owner October 8, 2025 14:46
Copy link
Collaborator

@dborovcanin dborovcanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't remove doc.go files.

@dborovcanin dborovcanin merged commit bc7727c into absmach:main Oct 8, 2025
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Domain metadata is cleared on domain name or domain tags update

2 participants