SMQ-3028 - Unify SMQ certs with Absmach Certs #3146

nyagamunene · 2025-09-17T08:51:59Z

What type of PR is this?

What does this do?

Which issue(s) does this PR fix/relate to?

Related Issue Unify SMQ certs with Absmach Certs #3028
Resolves Unify SMQ certs with Absmach Certs #3028

Have you included tests for your changes?

Did you document any new/modified feature?

Notes

codecov · 2025-09-22T09:12:44Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.09%. Comparing base (b031dc0) to head (0d95f14).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #3146       +/-   ##
===========================================
+ Coverage   35.47%   46.09%   +10.61%     
===========================================
  Files         319      231       -88     
  Lines       48061    35267    -12794     
===========================================
- Hits        17052    16255      -797     
+ Misses      30154    18192    -11962     
+ Partials      855      820       -35

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>

felixgateru · 2025-09-30T10:14:36Z

docker/addons/certs/Dockerfile

+
+FROM scratch
+
+# Required for billing service


Suggested change

# Required for billing service

# Required for certs service

felixgateru · 2025-09-30T10:14:49Z

docker/addons/certs/Dockerfile.dev

+ARG SVC
+COPY --from=alpine:latest /etc/ssl/certs/ca-certificates.crt /etc/ssl/certs/ca-certificates.crt
+COPY ./build/$SVC /exe
+ENTRYPOINT ["/exe"]


Add empty line

felixgateru · 2025-09-30T10:17:27Z

docker/addons/certs/docker-compose.yaml

      - openbao
      - certs-db
-    restart: on-failure
+    restart: always


Why restart always here?

felixgateru · 2025-09-30T10:21:57Z

docker/certs-docker-compose-override.yml

remove if unused

felixgateru · 2025-09-30T10:23:31Z

pkg/sdk/clients_test.go

 	"github.com/stretchr/testify/mock"
 )

+var clientID = "fe6b4e92-cc98-425e-b0aa-000000000001"


is this used?

It is used in multiple places in the code

arvindh123 · 2025-09-30T10:28:55Z

scripts/certs.sh

@@ -0,0 +1,42 @@
+#!/bin/bash


Why do we need to use the same docker compose?

I agree, this is probably not needed. We can just put a simple compose file that uses absmach/certs to docker/addons.

What about when we update certs and we need the changes reflected on supermq will it not be alot of work making the changes on superMQ side?

I don't think so. SMQ is only using Compose from Certs. However, now that we're working on integrations service, I'm thinking that Certs service will become even more important and I'm afraid we can't avoid coupling between Certs and core service. Anyways, let's keep this as is, and we'll revisit the approach during this sprint as we progress with integrations.

nyagamunene added this to SuperMQ Sep 18, 2025

nyagamunene moved this to 🚧 In Progress in SuperMQ Sep 18, 2025

nyagamunene self-assigned this Sep 18, 2025

nyagamunene force-pushed the unify_certs branch 2 times, most recently from 8108137 to b5c335a Compare September 22, 2025 07:41

nyagamunene marked this pull request as ready for review September 22, 2025 10:50

nyagamunene requested a review from a team as a code owner September 22, 2025 10:50

nyagamunene moved this from 🚧 In Progress to 🩺 Review and testing in SuperMQ Sep 22, 2025

arvindh123 moved this from 🩺 Review and testing to 🚀 Ready for merge in SuperMQ Sep 25, 2025

arvindh123 moved this from 🚀 Ready for merge to 🩺 Review and testing in SuperMQ Sep 25, 2025

nyagamunene added 19 commits September 30, 2025 12:44

remove certs files

045d3a7

Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>

unify certs

3ce27c6

Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>

fix mockery tool

b937fd1

Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>

update certs tests in sdk

9cefa4b

Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>

update variables

072825c

Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>

update ci

b1b637c

Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>

update certs

d281324

Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>

update go mod file

1f3feb7

Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>

update go mod file

20702c6

Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>

update certs

e3e6299

Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>

update go mod file

cf7afb8

Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>

fix failing linter

f4625af

Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>

update api docs

bef58a0

Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>

remove certs sdk and cli

c87f7c4

Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>

update test yaml

95b7df3

Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>

update go mod file

6a92563

Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>

update cli file

bb2beef

Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>

fix failing linter

d549001

Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>

update go mod file

56d6150

Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>

nyagamunene added 13 commits September 30, 2025 12:46

update certs

94055c6

Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>

remove unused code

4d1ac6c

Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>

remove failing tests

27ff259

Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>

update tests

d5d2751

Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>

update sdk tests

8bb181e

Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>

uncomment code

03adbce

Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>

makefile

2700333

Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>

update run_addons command

ddc8f17

Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>

fix domain tests

b0cbe4e

Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>

fix users tests

d288e85

Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>

fix domain tests

69a2d7b

Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>

fix users tests

aa95f41

Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>

fix clients tests

6498ad2

Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>

nyagamunene force-pushed the unify_certs branch from 6469277 to 6498ad2 Compare September 30, 2025 09:52

update certs

0d95f14

Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>

felixgateru requested changes Sep 30, 2025

View reviewed changes

github-project-automation bot moved this from 🩺 Review and testing to 🚧 In Progress in SuperMQ Sep 30, 2025

arvindh123 requested changes Sep 30, 2025

View reviewed changes

dborovcanin approved these changes Oct 1, 2025

View reviewed changes

dborovcanin merged commit ae7c930 into absmach:main Oct 1, 2025
8 of 9 checks passed

github-project-automation bot moved this from 🚧 In Progress to ✅ Done in SuperMQ Oct 1, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

SMQ-3028 - Unify SMQ certs with Absmach Certs #3146

SMQ-3028 - Unify SMQ certs with Absmach Certs #3146

Uh oh!

nyagamunene commented Sep 17, 2025

Uh oh!

codecov bot commented Sep 22, 2025 •

edited

Loading

Uh oh!

felixgateru Sep 30, 2025

Uh oh!

felixgateru Sep 30, 2025

Uh oh!

felixgateru Sep 30, 2025

Uh oh!

felixgateru Sep 30, 2025

Uh oh!

felixgateru Sep 30, 2025

Uh oh!

nyagamunene Sep 30, 2025

Uh oh!

arvindh123 Sep 30, 2025

Uh oh!

dborovcanin Oct 1, 2025

Uh oh!

nyagamunene Oct 1, 2025

Uh oh!

dborovcanin Oct 1, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

SMQ-3028 - Unify SMQ certs with Absmach Certs #3146

SMQ-3028 - Unify SMQ certs with Absmach Certs #3146

Uh oh!

Conversation

nyagamunene commented Sep 17, 2025

What type of PR is this?

What does this do?

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Did you document any new/modified feature?

Notes

Uh oh!

codecov bot commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dborovcanin Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Sep 22, 2025 •

edited

Loading

dborovcanin Oct 1, 2025 •

edited

Loading