Skip to content

Conversation

@Musilah
Copy link
Contributor

@Musilah Musilah commented Aug 21, 2025

What type of PR is this?

This is an optimization because it improves the following functionality: updates Sorting of entities

What does this do?

It updates entity sorting to use updated_at variable correctly

Which issue(s) does this PR fix/relate to?

N/A

  • Related Issue #
  • Resolves #

Have you included tests for your changes?

N/A

Did you document any new/modified feature?

Notes

@Musilah Musilah force-pushed the updatedATSorting branch 2 times, most recently from b01374d to cbd8fda Compare August 21, 2025 10:57
@codecov
Copy link

codecov bot commented Aug 21, 2025

Codecov Report

❌ Patch coverage is 33.84615% with 43 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.21%. Comparing base (1efa8b5) to head (e35f7d5).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
users/postgres/users.go 0.00% 13 Missing and 1 partial ⚠️
channels/postgres/channels.go 25.00% 9 Missing ⚠️
domains/postgres/domains.go 25.00% 9 Missing ⚠️
groups/postgres/groups.go 50.00% 5 Missing and 1 partial ⚠️
clients/postgres/clients.go 64.28% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3076       +/-   ##
===========================================
+ Coverage   35.16%   45.21%   +10.04%     
===========================================
  Files         326      163      -163     
  Lines       48198    30637    -17561     
===========================================
- Hits        16948    13851     -3097     
+ Misses      30399    16073    -14326     
+ Partials      851      713      -138     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Musilah Musilah marked this pull request as ready for review September 4, 2025 12:19
@Musilah Musilah requested a review from a team as a code owner September 4, 2025 12:19
@dborovcanin
Copy link
Collaborator

@Musilah CI is failing.

Signed-off-by: Musilah <nataleigh.nk@gmail.com>
Signed-off-by: Musilah <nataleigh.nk@gmail.com>
Signed-off-by: Musilah <nataleigh.nk@gmail.com>
Signed-off-by: Musilah <nataleigh.nk@gmail.com>
Signed-off-by: musilah <nataleigh.nk@gmail.com>
Signed-off-by: musilah <nataleigh.nk@gmail.com>
Signed-off-by: musilah <nataleigh.nk@gmail.com>
Signed-off-by: musilah <nataleigh.nk@gmail.com>
Actions: []string{},
Order: "updated_at",
Dir: "asc",
Dir: "desc",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add test for this, i.e. test the order of returned elements, but we should do it in a separate PR.

@dborovcanin dborovcanin merged commit c50221a into absmach:main Sep 5, 2025
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants