-
Notifications
You must be signed in to change notification settings - Fork 673
NOISSUE - Update entity sorting #3076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b01374d to
cbd8fda
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3076 +/- ##
===========================================
+ Coverage 35.16% 45.21% +10.04%
===========================================
Files 326 163 -163
Lines 48198 30637 -17561
===========================================
- Hits 16948 13851 -3097
+ Misses 30399 16073 -14326
+ Partials 851 713 -138 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0c82a52 to
7276ae2
Compare
7276ae2 to
e0dcb67
Compare
|
@Musilah CI is failing. |
29c01d4 to
e886baf
Compare
Signed-off-by: Musilah <nataleigh.nk@gmail.com>
Signed-off-by: Musilah <nataleigh.nk@gmail.com>
Signed-off-by: Musilah <nataleigh.nk@gmail.com>
Signed-off-by: Musilah <nataleigh.nk@gmail.com>
Signed-off-by: musilah <nataleigh.nk@gmail.com>
Signed-off-by: musilah <nataleigh.nk@gmail.com>
Signed-off-by: musilah <nataleigh.nk@gmail.com>
e886baf to
e35f7d5
Compare
| Actions: []string{}, | ||
| Order: "updated_at", | ||
| Dir: "asc", | ||
| Dir: "desc", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add test for this, i.e. test the order of returned elements, but we should do it in a separate PR.
What type of PR is this?
This is an optimization because it improves the following functionality: updates Sorting of entities
What does this do?
It updates entity sorting to use updated_at variable correctly
Which issue(s) does this PR fix/relate to?
N/A
Have you included tests for your changes?
N/A
Did you document any new/modified feature?
Notes