SMQ-3097 - Add NATs throttling in messaging #3074
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyagamunene
force-pushed
the
add_NATS_throttling
branch
from
6865970 to
c1c2d86
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3074 +/- ##
===========================================
+ Coverage 35.47% 47.41% +11.93%
===========================================
Files 319 52 -267
Lines 48061 3109 -44952
===========================================
- Hits 17052 1474 -15578
+ Misses 30154 1538 -28616
+ Partials 855 97 -758 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dborovcanin
requested changes
Aug 21, 2025
pkg/messaging/nats/options.go
Outdated
Comment on lines
68
to
72
| slowConsumerConfig: &SlowConsumerConfig{ | ||
| MaxPendingMsgs: defaultMaxPendingMsgs, | ||
| MaxPendingBytes: defaultMaxPendingBytes, | ||
| EnableDroppedMsgTracking: defaultEnableDroppedMsgTracking, | ||
| EnableSlowConsumerDetection: defaultEnableSlowConsumerDetection, |
There was a problem hiding this comment.
Can we move this to the jsStreamConfig?
pkg/messaging/nats/pubsub.go
Outdated
Comment on lines
290
to
296
| // checkConsumerLag checks the consumer lag and logs warnings if thresholds are exceeded. | ||
| // This provides additional slow consumer detection for JetStream consumers. | ||
| func (ps *pubsub) checkConsumerLag(ctx context.Context, consumerName string) { | ||
| if ps.slowConsumerConfig == nil || !ps.slowConsumerConfig.EnableSlowConsumerDetection { | ||
| return | ||
| } | ||
|
|
There was a problem hiding this comment.
Is this needed at all? Isn't natsErrorHandler going to handle these scenarios anyway?
dborovcanin
force-pushed
the
add_NATS_throttling
branch
2 times, most recently
from
a8a732b to
b79a933
Compare
nyagamunene
force-pushed
the
add_NATS_throttling
branch
from
b79a933 to
b8e6999
Compare
dborovcanin
force-pushed
the
add_NATS_throttling
branch
from
b8e6999 to
a6dfaa6
Compare
arvindh123
changed the title
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
dborovcanin
force-pushed
the
add_NATS_throttling
branch
from
a6dfaa6 to
0f6df07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this do?
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Did you document any new/modified feature?
Notes