-
Notifications
You must be signed in to change notification settings - Fork 673
NOISSUE - Pass context on SDK to allow distributed tracing #2783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces distributed tracing support by passing context to all SDK calls in the CLI commands and updates mock generation versions.
- Update SDK calls to include context by using cmd.Context() in all CLI files
- Upgrade mockery generated files from v2.43.2 to v2.53.2
- Update the GitHub workflow to align with the new mockery version
Reviewed Changes
Copilot reviewed 82 out of 82 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| cli/clients.go | Added context parameter to multiple SDK calls |
| cli/channels.go | Added context parameter to multiple SDK calls |
| cli/certs.go | Added context parameter to multiple SDK calls |
| channels/private/mocks/service.go | Updated mockery version in generated header |
| channels/mocks/service.go | Updated mockery version in generated header |
| channels/mocks/repository.go | Updated mockery version in generated header |
| channels/mocks/channels_client.go | Updated mockery version in generated header |
| certs/service.go | Reordered parameters to pass context when retrieving clients |
| certs/mocks/service.go | Updated mockery version in generated header |
| certs/mocks/pki.go | Updated mockery version in generated header |
| auth/mocks/token_client.go | Updated mockery version in generated header |
| auth/mocks/service.go | Updated mockery version in generated header |
| auth/mocks/patsrepo.go | Updated mockery version in generated header |
| auth/mocks/pats.go | Updated mockery version in generated header |
| auth/mocks/keys.go | Updated mockery version in generated header |
| auth/mocks/hasher.go | Updated mockery version in generated header |
| auth/mocks/callback.go | Updated mockery version in generated header |
| auth/mocks/cache.go | Updated mockery version in generated header |
| auth/mocks/authz.go | Updated mockery version in generated header |
| .github/workflows/check-generated-files.yaml | Updated mockery version used to check generated files |
|
@SammyOina Please resolve conflicts. |
e075e8c to
65fb59c
Compare
65fb59c to
8d72157
Compare
|
Please fix the CI. |
8d72157 to
baf33a0
Compare
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
…for clientID Signed-off-by: Sammy Oina <sammyoina@gmail.com>
…proved accuracy Signed-off-by: Sammy Oina <sammyoina@gmail.com>
baf33a0 to
0058af0
Compare
… for improved accuracy Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
…proved accuracy Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2783 +/- ##
==========================================
+ Coverage 27.56% 31.06% +3.49%
==========================================
Files 351 65 -286
Lines 55271 15164 -40107
==========================================
- Hits 15234 4710 -10524
+ Misses 39287 10205 -29082
+ Partials 750 249 -501 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
What type of PR is this?
This is a refactor of sdk methods
What does this do?
This PR introduces distributed tracing support by passing context to all SDK calls in the CLI commands and updates mock generation versions.
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Did you document any new/modified feature?
Notes