Skip to content

Conversation

@felixgateru
Copy link
Contributor

@felixgateru felixgateru commented Mar 28, 2025

What type of PR is this?

This is a refactor as it renames domain alias to route.

What does this do?

This pr:

  • Renames alias to route in domains
  • Updates requirements for the route format.

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Yes, tests have been included for new methods and updated for existing ones.

Did you document any new/modified feature?

Yes, in code documentation has been updated

Notes

None

@codecov
Copy link

codecov bot commented Mar 28, 2025

Codecov Report

Attention: Patch coverage is 46.66667% with 56 lines in your changes missing coverage. Please review.

Project coverage is 29.64%. Comparing base (3931eca) to head (75ab501).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
domains/mocks/repository.go 0.00% 34 Missing ⚠️
domains/postgres/domains.go 76.74% 7 Missing and 3 partials ⚠️
domains/api/http/requests.go 38.46% 5 Missing and 3 partials ⚠️
domains/events/events.go 0.00% 3 Missing ⚠️
domains/middleware/logging.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2776      +/-   ##
==========================================
+ Coverage   27.54%   29.64%   +2.09%     
==========================================
  Files         351      253      -98     
  Lines       55274    47765    -7509     
==========================================
- Hits        15226    14160    -1066     
+ Misses      39297    32949    -6348     
+ Partials      751      656      -95     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@felixgateru felixgateru marked this pull request as ready for review March 28, 2025 11:09
@felixgateru felixgateru requested a review from a team as a code owner March 28, 2025 11:09
@felixgateru felixgateru changed the title SMQ-2760 - Rename domain alias to topic SMQ-2760 - Rename domain alias to route Apr 1, 2025
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
@dborovcanin dborovcanin merged commit b79fdb1 into absmach:main Apr 2, 2025
8 of 9 checks passed
@felixgateru felixgateru deleted the smq2760-topic branch May 29, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants