NOISSUE - Group service middleware into single folder #2472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixgateru
force-pushed
the
noissue-middleware
branch
3 times, most recently
from
be16129 to
8128e0d
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2472 +/- ##
==========================================
+ Coverage 34.49% 43.66% +9.17%
==========================================
Files 318 211 -107
Lines 46477 33458 -13019
==========================================
- Hits 16030 14608 -1422
+ Misses 29651 18107 -11544
+ Partials 796 743 -53 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rodneyosodo
requested changes
Oct 22, 2024
felixgateru
force-pushed
the
noissue-middleware
branch
from
430d8c0 to
5de0889
Compare
felixgateru
force-pushed
the
noissue-middleware
branch
from
5de0889 to
655b913
Compare
felixgateru
force-pushed
the
noissue-middleware
branch
2 times, most recently
from
f7a9075 to
49da8ce
Compare
|
@felixgateru Please resolve conflicts. |
felixgateru
force-pushed
the
noissue-middleware
branch
from
49da8ce to
dd77778
Compare
felixgateru
force-pushed
the
noissue-middleware
branch
from
dd77778 to
c4c6771
Compare
felixgateru
force-pushed
the
noissue-middleware
branch
from
c4c6771 to
6fc2d52
Compare
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
dborovcanin
force-pushed
the
noissue-middleware
branch
from
6fc2d52 to
eef1496
Compare
dborovcanin
requested changes
Sep 25, 2025
clients/middleware/doc.go
Outdated
Comment on lines
4
to
8
| // Package middleware provides authorization, logging, metrics and tracing middleware | ||
| // for Magistrala Clients Service. | ||
| // | ||
| // For more details about tracing instrumentation for Magistrala messaging refer | ||
| // to the documentation at https://docs.magistrala.abstractmachines.fr/tracing/. |
There was a problem hiding this comment.
This is SuperMQ, not Magistrala.
Comment on lines
4
to
8
| // Package middleware provides tracing, logging and metrics middleware | ||
| // for Magistrala Notifiers service. | ||
| // | ||
| // For more details about tracing instrumentation for Magistrala messaging refer | ||
| // to the documentation at https://docs.magistrala.abstractmachines.fr/tracing/. |
provision/middleware/doc.go
Outdated
Comment on lines
4
to
5
| // Package middleware provides logging middleware for Magistrala | ||
| // Provision service. |
There was a problem hiding this comment.
Same. Check other MG references as well.
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
dborovcanin
requested changes
Sep 26, 2025
| logger *slog.Logger | ||
| } | ||
|
|
||
| // NewRoleManagerLoggingMiddleware adds logging facilities to the core service. |
There was a problem hiding this comment.
Use the same approach: NewLogging (and NewAuth snd NewMetric) here, so we have something like middlewarealias.NewLogging....
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
dborovcanin
requested changes
Sep 26, 2025
channels/middleware/authorization.go
Outdated
| return nil, err | ||
| } | ||
| ram, err := rmMW.NewRoleManagerAuthorizationMiddleware(policies.ChannelType, svc, authz, rolesOpPerm, callout) | ||
| ram, err := rmMW.NewAuthorization(policies.ChannelType, svc, authz, rolesOpPerm, callout) |
There was a problem hiding this comment.
Avoid using mixedCaps in package aliases. Use rolemw here.
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
dborovcanin
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a refactor as it groups current service middleware.
What does this do?
This pr creates the following folder structure for magistrala services:
service--
middleware----
authorization.go----
logging.go----
metrics.go----
tracing.go----
doc.goWhich issue(s) does this PR fix/relate to?
Noissue
Have you included tests for your changes?
No
Did you document any new/modified feature?
Yes changes include godoc documentation
Notes
To be merged after #2444