Skip to content

Add an add-on pipeline for collecting dwarfs from elfs #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Feb 19, 2024
+127 −0
Merged

Add an add-on pipeline for collecting dwarfs from elfs #1068

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
8051ec7
Add add-on pipeline for collecting dwarfs from elfs
TG1999 Feb 1, 2024
e6cc9b7
Add headers
TG1999 Feb 1, 2024
04f4122
Add tests for models
TG1999 Feb 1, 2024
4ca303e
Address review comments
TG1999 Feb 11, 2024
31eae95
Address review comments
TG1999 Feb 11, 2024
00ffa8e
Add documentation for pipeline
TG1999 Feb 11, 2024
4a3a0f8
Fix built-in pipelines file
TG1999 Feb 16, 2024
43ce108
Update built-in-pipelines.rst
tdruez Feb 19, 2024
add51cf
Update models.py
tdruez Feb 19, 2024
a698b6c
Revert python-inspector version
TG1999 Feb 19, 2024
83f1c1f
Use ELF instead of elf
TG1999 Feb 19, 2024
9b4dd77
Address review comments
TG1999 Feb 19, 2024
5d0d4df
Fix tests
TG1999 Feb 19, 2024
b1416a4
Correct reference in builtin-pipelines.rst
TG1999 Feb 19, 2024
52817ae
Update CHANGELOG.rst
tdruez Feb 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scanpipe/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1948,7 +1948,7 @@ def has_directory_content_fingerprint(self):

def elfs(self):
"""
Resources that are ``files`` and their filetype starts with "elf" and
Resources that are ``files`` and their filetype starts with "ELF" and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not correct, the string is still "elf"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

contains any of these "executable", "relocatable", "shared object".
Keep sync with the content type implementation at ``typecode.contenttype``.
"""
Expand Down
2 changes: 1 addition & 1 deletion scanpipe/pipelines/inspect_elf_binaries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
from scanpipe.pipelines import Pipeline


class InspectElfBinaries(Pipeline):
class InspectELFBinaries(Pipeline):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update the references to this as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

"""Inspect ELF binaries and collect DWARF paths."""

download_inputs = False
Expand Down