Skip to content

k3s customizable listen port #1416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

k3s customizable listen port #1416

wants to merge 9 commits into from

Conversation

@blast-hardcheese
Copy link
Contributor

@blast-hardcheese blast-hardcheese commented Sep 25, 2025 •
edited
Loading

Resolves #467

  • upgrade nix infrastructure to support golang 1.23.x
  • formatting
  • exposing a way to customize the k3s listen port

@blast-hardcheese blast-hardcheese force-pushed the dstewart/customizable-listenPort branch from 8bdaac2 to 1c54382 Compare September 25, 2025 06:37
@blast-hardcheese blast-hardcheese marked this pull request as draft September 25, 2025 06:45
@blast-hardcheese
Copy link
Contributor Author

one more change required for nix flake fixes

@blast-hardcheese blast-hardcheese force-pushed the dstewart/customizable-listenPort branch from 1c54382 to e0c9053 Compare September 25, 2025 06:46
@blast-hardcheese blast-hardcheese marked this pull request as ready for review September 25, 2025 06:47
@blast-hardcheese
Copy link
Contributor Author

OK. Also tested nix build as well as consuming this branch via flake.

@abiosoft
Copy link
Owner

That is impressive, thanks :)

I however prefer the variable is simply port instead of listenPort.

abiosoft
abiosoft reviewed Sep 25, 2025
View reviewed changes
abiosoft
abiosoft reviewed Sep 25, 2025
View reviewed changes
abiosoft
abiosoft reviewed Sep 25, 2025
View reviewed changes
abiosoft
abiosoft reviewed Sep 25, 2025
View reviewed changes
abiosoft
abiosoft reviewed Sep 25, 2025
View reviewed changes
blast-hardcheese and others added 7 commits September 25, 2025 10:43
@blast-hardcheese @abiosoft
Bump flake to a compatible golang version
38775bd 
Signed-off-by: Devon Stewart <blast@hardchee.se>
@blast-hardcheese @abiosoft
nix flake update
bc8bf2c 
Signed-off-by: Devon Stewart <blast@hardchee.se>
@blast-hardcheese @abiosoft
Add gotools to ensure we have goimports
491141c 
Signed-off-by: Devon Stewart <blast@hardchee.se>
@blast-hardcheese @abiosoft
make fmt
018c844 
Signed-off-by: Devon Stewart <blast@hardchee.se>
@blast-hardcheese @abiosoft
Clarify drifted arg name
e514c5e 
Signed-off-by: Devon Stewart <blast@hardchee.se>
@blast-hardcheese @abiosoft
Thread .kubernetes.listenPort through to install functions
93a1be1 
Signed-off-by: Devon Stewart <blast@hardchee.se>
@abiosoft
chore: apply suggestions from code review
7daed93
@abiosoft abiosoft force-pushed the dstewart/customizable-listenPort branch from 3243f77 to 7daed93 Compare September 25, 2025 09:43
abiosoft
abiosoft reviewed Sep 25, 2025
View reviewed changes
abiosoft
abiosoft reviewed Sep 25, 2025
View reviewed changes
@abiosoft
Copy link
Owner

I need to push out a hotfix and couldn't wait any longer for the needed changes.
I have created #1419 and moved your commits over to ensure you get the credit.

Thanks :)

@abiosoft abiosoft closed this Sep 25, 2025
@blast-hardcheese blast-hardcheese deleted the dstewart/customizable-listenPort branch September 25, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abiosoft abiosoft abiosoft left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: add support for setting kubernetes server port (or automate based on profiles to avoid overlap)

2 participants

@blast-hardcheese @abiosoft