Skip to content

Conversation

@KeyaMallick
Copy link

@KeyaMallick KeyaMallick commented Dec 30, 2024

Pull Request for DL-Simplified 💡

Issue Title : Replacing ':' to '-' as windows System don't allow colony in naming

Closes: #issue number that will be closed through this PR

Describe the add-ons or changes you've made 📃

Give a clear description of what have you added or modifications made

Type of change ☑️

What sort of change have you made:

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

Describe how it has been tested
Describe how have you verified the changes made

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

@github-actions
Copy link

Our team will soon review your PR. Thanks @KeyaMallick :)

@abhisheks008
Copy link
Owner

Hi @KeyaMallick thanks for the quick fix. Your PR is merged.

@abhisheks008 abhisheks008 added bug Something isn't working Status: Approved Approved PR by the PA. labels Dec 31, 2024
@abhisheks008 abhisheks008 merged commit 95c4f08 into abhisheks008:main Dec 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Status: Approved Approved PR by the PA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants