Skip to content

Conversation

@devmuse7
Copy link
Contributor

@devmuse7 devmuse7 commented Oct 3, 2024

Pull Request for DL-Simplified 💡

Issue Title : Stock Analysis #893

  • Info about the related issue (Aim of the project) : this project provide the analysis of the provided stock like unseen pattern visualization etc
  • Name: Surbhi Bahukhandi
  • GitHub ID: Itachii27
  • Email ID: surbhibahukhandi199928@gmail.com
  • **Idenitfy yourself: GSSOC-EXTD and Hacktoberfest contributor

Closes: #893

Describe the add-ons or changes you've made 📃

Give a clear description of what have you added or modifications made

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

Describe how it has been tested
Describe how have you verified the changes made

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

@github-actions
Copy link

github-actions bot commented Oct 3, 2024

Our team will soon review your PR. Thanks @Itachii27 :)

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Itachii27 your model implementation looks good to me. Need some minor changes/updation in the README file. Follow the template and update the README file accordingly.

Here is the template, https://github.com/abhisheks008/DL-Simplified/blob/main/.github/readme_template.md

@devmuse7
Copy link
Contributor Author

devmuse7 commented Oct 5, 2024

Hi @abhisheks008 I have done the changes as requested. Please review the PR again

@devmuse7
Copy link
Contributor Author

Hi @abhisheks008 I have done the changes. Please review the PR

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Your PR is approved and ready to be merged.
@Itachii27

@abhisheks008 abhisheks008 added Status: Approved Approved PR by the PA. level 2 Level 2 for GSSOC hacktoberfest-accepted and removed Status: Requested Changes Changes requested. labels Oct 13, 2024
@abhisheks008 abhisheks008 merged commit 8acaec7 into abhisheks008:main Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stock Analysis

2 participants