Test vector cleanups #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes in [1] harmonize `longfellow-zk`'s `zk_test.cc` with other tests in that project. In particular, it addresses discrepancies in Fiat-Shamir transcript initialization and pad generation. Additionally, it augments the test so that it emits a test vector as JSON. This corresponding change adopts the new test vector value thus generated, and makes improvements to our own test vector code. - Introduce a `test_vector` module refactored out of `circuit::tests` - Remove hacks in `sumcheck::Prover` - Add a yet-unused Ligero proof to test vector [1]: https://github.com/tgeoghegan/longfellow-zk/tree/zk-test-cleanup
divergentdave
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in 1 (see also as a pull request in tgeoghegan/longfellow-zk#1) harmonize
longfellow-zk'szk_test.ccwith other tests in that project. In particular, it addresses discrepancies in Fiat-Shamir transcript initialization and pad generation. Additionally, it augments the test so that it emits a test vector as JSON.This corresponding change adopts the new test vector value thus generated, and makes improvements to our own test vector code.
test_vectormodule refactored out ofcircuit::testssumcheck::Prover