Feature/mobile row variant #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshKyd
reviewed
Apr 17, 2025
| color: var(--panel-color); | ||
| border-radius: var(--panel-radius); | ||
| padding: var(--panel-padding); | ||
| max-width: 640px; |
There was a problem hiding this comment.
Ben said: "Tablet text line length should max out at 640px" - Perhaps we need to check with him if that's for only that one breakpoint? I suspect that it's a readability thing that applies in general
There was a problem hiding this comment.
Gotcha. Let's check, because it might make it a bit tight on large desktop. Also let's convert it to rems, that's what the rest of the stylesheet is using
| if ($isMobileRowMode) { | ||
| // For row layout on small portrait screens, block out space taken up by the viz at the top | ||
| const threshold = ($vizDims.dims[1] / $screenDims[1]) * 100; | ||
| // console.log($vizDims, $screenDims, threshold); |
There was a problem hiding this comment.
Suggested change
| // console.log($vizDims, $screenDims, threshold); |
| import acto from '@abcnews/alternating-case-to-object'; | ||
| import { selectMounts, isMount, getMountValue } from '@abcnews/mount-utils'; | ||
| import type { PanelAlignment, PanelDefinition, ScrollytellerDefinition } from './types.js'; | ||
| import type { PanelDefinition, ScrollytellerDefinition } from './types.js'; |
There was a problem hiding this comment.
If we're not using PanelAlignment let's delete it from types.js too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.