Skip to content

Conversation

@drzax
Copy link
Member

@drzax drzax commented Aug 8, 2025

Also adds a bunch more type definitions.

@AshKyd — I'd be interested to know how this compares to the image part of https://github.com/abcnews/interactive-hero-images

I think it makes reasonable assumptions about what to do at different viewport sizes, but there is definitely some compromise.

@drzax drzax marked this pull request as ready for review August 8, 2025 06:55
@drzax drzax requested review from AshKyd and phocks August 8, 2025 06:55
@AshKyd
Copy link
Member

AshKyd commented Aug 8, 2025

I can't really tell what's going on here, maybe we could go through it next week?

@github-actions
Copy link

Playwright visual snapshot differences were detected.

View the Playwright report to review the visual differences.
To approve the snapshot changes and update the snapshots, please comment: /approve-snapshots

@github-actions
Copy link

Playwright visual snapshot differences were detected.

View the Playwright report to review the visual differences.
To approve the snapshot changes and update the snapshots, please comment: /approve-snapshots

@github-actions
Copy link

Playwright visual snapshot differences were detected.

View the Playwright report to review the visual differences.
To approve the snapshot changes and update the snapshots, please comment: /approve-snapshots

@drzax drzax force-pushed the use-original-header branch from d2b0c34 to 81eafee Compare August 11, 2025 07:05
@drzax
Copy link
Member Author

drzax commented Aug 11, 2025

Thanks for the convo on this yesterday @AshKyd, it led to a number of small but good improvements. I'm keen to merge this asap, but if you feel like having a quick look, I'd welcome the additional eyes.

@drzax drzax merged commit 79edbbb into main Aug 11, 2025
1 check passed
@drzax drzax deleted the use-original-header branch August 11, 2025 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants