Svelte 5 #230
Merged
Svelte 5 #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…preact projects - new versions of libraries in package-lock.json were causing tests to fail - verbatimModuleSyntax was set to true in tsconfig.json for svelte 5 ts projects to work. the syntax for importing types in preact and react ts projects needed to be updated to adhere to this change
|
This looks great, thanks @thomasbrettell! Have you tested it against any existing svelte 4 projects? I'm guessing it should work for them too. |
|
Hi @drzax. Just seeing this now as I've been away. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the webpack svelte rules to follow those specified here.
For typescript projects
verbatimModuleSyntaxintsconfig.jsonneeded to be set to true other wise imports inside<script lang='ts>blocks would be undefined (https://github.com/tsconfig/bases/blob/main/bases/svelte.json). Due to this I also updated react and preact typescript templates.import { createRoot, Root } from 'react-dom/client';-->import { createRoot, type Root } from 'react-dom/client';