Fixed panic issue in timeseries and uploaded two new GIFS for readme #20
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a critical concurrency panic issue in the WebSocket handlers by implementing proper synchronization patterns. The fix addresses race conditions that occur when concurrent read/write operations happen on shared client maps during WebSocket message broadcasting.
- Fixed race condition in timeseries WebSocket handler by copying clients before releasing the read lock
- Fixed similar race condition in k8s WebSocket hub by deferring client removal operations
- Added new "Observability" section to navigation
Reviewed Changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| internal/server/handlers_timeseries.go | Fixes concurrent map access by copying clients slice before iteration |
| internal/k8s/ws/hub.go | Prevents race condition by deferring client removal until after message broadcast |
| frontend/src/components/nav-main.tsx | Adds new Observability navigation section |
| README.md | Updates documentation with new GIF assets and feature descriptions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| } | ||
| } | ||
| h.mu.RUnlock() | ||
|
|
There was a problem hiding this comment.
[nitpick] Remove the extra whitespace on line 182. Consistent spacing improves code readability.
Copilot uses AI. Check for mistakes.
| </SidebarGroup> | ||
| </> | ||
| ); | ||
|
|
There was a problem hiding this comment.
[nitpick] Remove the unnecessary blank line before the closing brace. This maintains consistent formatting with the rest of the codebase.
Copilot uses AI. Check for mistakes.
1 participant
No description provided.