chore(deps): Update python samples' optional deps #191
Conversation
In future versions of a2a-sdk, HTTP server packages may become optional. See a2aproject/a2a-python/pull/217 for details. This PR ensures that agents in `samples/python/agents/` continue to work with the future versions on a2a-sdk. Refs a2aproject#190
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @darkhaniop, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the optional dependencies for Python samples to ensure continued functionality with future versions of the a2a-sdk. Specifically, it addresses upcoming changes where HTTP server packages within the SDK may become optional, by explicitly adding necessary HTTP-related dependencies to the sample agents.
Highlights
- Dependency Alignment: Explicitly adds
sse-starletteandstarletteas direct dependencies to several Python sample agents (analytics,helloworld,langgraph,azureaifoundry_sdk) to maintain compatibility with futurea2a-sdkversions where HTTP server components might be optional. - SDK Version Update: Bumps the
a2a-sdkversion inuv.lockfiles across multiple samples, reflecting an upgrade to0.2.10(from0.2.4or0.2.5). - Transitive Dependency Resolution: Updates and adds numerous transitive dependencies within the
uv.lockfiles (e.g.,grpcio,protobuf,langchain-core,langsmith,openai,tiktoken,distro,jiter,regex,setuptools,cachetools,google-api-core,google-auth,googleapis-common-protos,grpcio-reflection,grpcio-tools,pyasn1,pyasn1-modules,rsa,fastapi), ensuring a consistent and functional dependency tree for the updated SDK and explicit HTTP packages. - Python Version Compatibility: Adjusts the minimum required Python version in
azureaifoundry_sdk/azurefoundryagent/uv.lockfrom>=3.13to>=3.12and adds resolution markers for Python 3.13.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates optional dependencies for Python samples to ensure compatibility with future versions of a2a-sdk. The changes correctly add starlette and sse-starlette to the pyproject.toml files. The lock files have been updated accordingly. I've found one issue in samples/python/agents/langgraph/uv.lock where a new dependency seems to have been added inconsistently. Please see my comment for details.
This issue was noted by the automated code review bot.
|
@gemini-code-assist review |
There was a problem hiding this comment.
Code Review
This pull request updates the Python samples' dependencies to explicitly include HTTP server packages like starlette and sse-starlette, ensuring they work with future versions of a2a-sdk where these might become optional. The lock files have been updated accordingly, which also brings in several other dependency updates. The changes look good and align with the PR's objective. I have one comment regarding the Python version change in one of the lock files.
Description
In future versions of a2a-sdk, HTTP server packages may become optional. See a2aproject/a2a-python/pull/217 for details. This PR ensures that agents in
samples/python/agents/continue to work with future versions of a2a-sdk.Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
CONTRIBUTINGGuide.Fixes #190 🦕