-
Notifications
You must be signed in to change notification settings - Fork 160
feat: Update A2A types from specification 🤖 #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update A2A types from specification 🤖 #319
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @a2a-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request is an automated update to synchronize the Python A2A type definitions in src/a2a/types.py
with the latest external A2A specification. The changes primarily involve a minor functional adjustment to a field's optionality and numerous formatting improvements to enhance code readability.
Highlights
- Type Definition Update: The
acceptedOutputModes
field within theMessageSendConfiguration
class has been updated to be optional (list[str] | None
) and now defaults toNone
. This change reflects an update in the underlying A2A specification. - Code Formatting and Readability: Several type definitions, particularly those using
RootModel
andField
declarations, have been reformatted. This involves condensing multi-line arguments into single lines to improve code conciseness and readability without altering functionality.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the A2A type definitions from the latest specification. The changes are mostly auto-generated and include one functional update to make a field optional, and several formatting changes that consolidate multi-line definitions into single lines.
My review focuses on the formatting changes, as several of them result in lines that exceed the standard PEP 8 line length recommendation, which can reduce readability. I've left suggestions to reformat these lines and recommended adding an automatic code formatter to the generation script to prevent this in the future. The functional change appears correct and consistent with the rest of the data model.
🤖 I have created a release *beep* *boop* --- ## [0.2.13](v0.2.12...v0.2.13) (2025-07-17) ### Features * Add `get_data_parts()` and `get_file_parts()` helper methods ([#312](#312)) ([5b98c32](5b98c32)) * Support for Database based Push Config Store ([#299](#299)) ([e5d99ee](e5d99ee)) * Update A2A types from specification 🤖 ([#319](#319)) ([18506a4](18506a4)) ### Bug Fixes * Add Input Validation for Task IDs in TaskManager ([#310](#310)) ([a38d438](a38d438)) * Add validation for empty artifact lists in `completed_task` ([#308](#308)) ([c4a324d](c4a324d)) * Handle readtimeout errors. ([#305](#305)) ([b94b8f5](b94b8f5)), closes [#249](#249) ### Documentation * Update Documentation Site Link ([#315](#315)) ([edf392c](edf392c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This PR updates
src/a2a/types.py
based on the latestspecification/json/a2a.json
from a2aproject/A2A.