-
Notifications
You must be signed in to change notification settings - Fork 160
refactor: Change Well-Known URI Magic Strings to a Constant defined in the specification #270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Change Well-Known URI Magic Strings to a Constant defined in the specification #270
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @a2a-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the A2A Python types in src/a2a/types.py
to align with the latest specification. The core changes involve introducing a new class to define well-known URIs and enhancing existing documentation to reference these new standardized paths, thereby improving protocol consistency and clarity.
Highlights
- New Type Definition for Well-Known URIs: A new
WellKnownUris
class has been introduced insrc/a2a/types.py
. This class defines standard well-known URIs for the A2A protocol, specifically addingAGENT_CARD_WELL_KNOWN_URI
as aLiteral
type with the value'/.well-known/agent.json'
. - AgentCard Documentation Enhancement: The docstring for the
AgentCard
class has been updated to include a recommendation that the AgentCard SHOULD be hosted at the well-known URI specified by the newWellKnownUris.AGENT_CARD_WELL_KNOWN_URI
constant.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the A2A type definitions in src/a2a/types.py
from the latest specification. It introduces a WellKnownUris
class and updates the AgentCard
docstring. I suggested using a simple class or Enum for WellKnownUris
and using a direct reference instead of a string literal for WellKnownUris.AGENT_CARD_WELL_KNOWN_URI
in the AgentCard
docstring.
This PR updates
src/a2a/types.py
based on the latestspecification/json/a2a.json
from a2aproject/A2A.