-
Notifications
You must be signed in to change notification settings - Fork 139
feat: support open agent discovery under shared base URL via API Catalog [PoC: DO NOT MERGE] #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
2aa4a5c
to
2bdc4f8
Compare
746d5b3
to
55ae0e3
Compare
@@ -1058,6 +1142,21 @@ class SetTaskPushNotificationConfigSuccessResponse(BaseModel): | |||
""" | |||
|
|||
|
|||
class AgentCatalog(BaseModel): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change will need to be approved in the A2A specification. https://github.com/google-a2a/A2A
This file is the current source of truth https://github.com/google-a2a/A2A/blob/main/types/src/types.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @holtskinner , thank you for the review!
Just a quick reminder: as mentioned in the PR description, this is a PoC and currently uses a temporary types.py
generated via datamodel-codegen
from a personal fork of the schema repository. This setup is only intended to demonstrate what integration might look like, and will be updated once the schema is finalized and available upstream.
To make this intent clearer, I’ll update the PR title accordingly as well. Thanks again for taking the time to look through it!
6e86e78
to
293dc75
Compare
I was exploring shared domain and this is right on time, thanks! If I understand correctly, this change requires agent catalog definition to have multiple agent card info into one catalog for agent discovery. Since this requires changes on a2a.json, will it be easier to adopt this feature by keeping the same schema with separate well-known locations, |
Hi @yangzhengzhiroy, thank you for your comment! Your understanding is mostly correct. While "API Catalog" might sound a bit grand, the idea is to support Open Discovery by exposing a list of agent endpoints via a One small clarification: according to the RFC for Well-Known URIs, the I'd really appreciate it if you could also take a look at this discussion and share your thoughts there! |
Hi @yangzhengzhiroy, thanks again for your input! I took another look at your comment and realized there might be a fundamental misunderstanding. To clarify:
So, it's more about publishing a directory of endpoints (including one or more Agent Cards per agent, if needed), rather than merging multiple agents’ information into one file. Hope that clears things up — happy to discuss further if needed! |
a5d84ae
to
1c49f84
Compare
48b7c3f
to
029f2df
Compare
6e0f8ca
to
62baf5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
51c4412
to
0066470
Compare
…log [PoC: DO NOT MERGE] Signed-off-by: Shingo OKAWA <shingo.okawa.g.h.c@gmail.com>
c103828
to
d048513
Compare
Description
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
CONTRIBUTING
Guide.nox -s format
from the repository root to format)Note:
This PR is currently not ready to be merged as it temporarily uses
types.py
generated from a personal fork of the schema repository. This will be replaced with an official schema source once it becomes available or is upstreamed.While this PR is primarily intended as a PoC/demo implementation, if google/A2A#642 is considered meaningful and accepted by the community, we may consider merging this implementation more formally into the project.
TODO
Fixes N/A 🦕