Skip to content

Conversation

@JuI3s
Copy link

@JuI3s JuI3s commented Oct 1, 2025

Description

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@JuI3s JuI3s changed the base branch from master to feat/fewer-reductions October 1, 2025 11:10
@markosg04 markosg04 changed the base branch from feat/fewer-reductions to dev/twist-shout October 10, 2025 20:47
@markosg04 markosg04 self-requested a review October 22, 2025 15:36
Copy link
Collaborator

@markosg04 markosg04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Mostly left some questions and nits.

Prior to merging, can we first confirm that Jolt CI passes when swapping the arkworks patch for the compression branch (no need to integrate or anything just want to ensure doesn't break Jolt -- which I don't think it should good to double check).


#[derive(Clone, Default, PartialEq, Eq)]
pub struct G1Config;
pub struct Config;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how come we renamed this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again I copied and pasted from the reference implementation in curves (which unfortunately I had to do the copying due to the way arkworks was setup...). I don't know why it's G1Config previously, but I checked the naming "Config" is consistent with the rest of arkworks codebase.

}
}

impl GLVConfig for Config {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we re-implementing this? just a bit confused

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are copy-paste from arkworks (unfortunately due to the replication in test-curve and curve I need to copy) which they implement. I didn't touch this part of the code.

@JuI3s
Copy link
Author

JuI3s commented Oct 29, 2025

Great job! Mostly left some questions and nits.

Prior to merging, can we first confirm that Jolt CI passes when swapping the arkworks patch for the compression branch (no need to integrate or anything just want to ensure doesn't break Jolt -- which I don't think it should good to double check).

How do you check "swapping the arkworks patch" work?

@markosg04
Copy link
Collaborator

Great job! Mostly left some questions and nits.
Prior to merging, can we first confirm that Jolt CI passes when swapping the arkworks patch for the compression branch (no need to integrate or anything just want to ensure doesn't break Jolt -- which I don't think it should good to double check).

How do you check "swapping the arkworks patch" work?

I think easiest way would just be swap the git link and branch in the Cargo.toml in Jolt with your link and branch

@JuI3s
Copy link
Author

JuI3s commented Nov 4, 2025

Great job! Mostly left some questions and nits.
Prior to merging, can we first confirm that Jolt CI passes when swapping the arkworks patch for the compression branch (no need to integrate or anything just want to ensure doesn't break Jolt -- which I don't think it should good to double check).

How do you check "swapping the arkworks patch" work?

I think easiest way would just be swap the git link and branch in the Cargo.toml in Jolt with your link and branch

I can't seem to do that easily as Dory depends on dev/twist-shout branch, so I would have a dep conflicts. I think it's ready to merge as the test suite for bn254 as is in this crate is pretty extensive.

@moodlezoup moodlezoup merged commit 0627041 into a16z:dev/twist-shout Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants