-
Notifications
You must be signed in to change notification settings - Fork 7
Torus compression #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
markosg04
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Mostly left some questions and nits.
Prior to merging, can we first confirm that Jolt CI passes when swapping the arkworks patch for the compression branch (no need to integrate or anything just want to ensure doesn't break Jolt -- which I don't think it should good to double check).
|
|
||
| #[derive(Clone, Default, PartialEq, Eq)] | ||
| pub struct G1Config; | ||
| pub struct Config; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how come we renamed this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again I copied and pasted from the reference implementation in curves (which unfortunately I had to do the copying due to the way arkworks was setup...). I don't know why it's G1Config previously, but I checked the naming "Config" is consistent with the rest of arkworks codebase.
| } | ||
| } | ||
|
|
||
| impl GLVConfig for Config { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we re-implementing this? just a bit confused
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are copy-paste from arkworks (unfortunately due to the replication in test-curve and curve I need to copy) which they implement. I didn't touch this part of the code.
How do you check "swapping the arkworks patch" work? |
I think easiest way would just be swap the git link and branch in the |
I can't seem to do that easily as Dory depends on dev/twist-shout branch, so I would have a dep conflicts. I think it's ready to merge as the test suite for bn254 as is in this crate is pretty extensive. |
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pendingsection inCHANGELOG.mdFiles changedin the GitHub PR explorer