-
Notifications
You must be signed in to change notification settings - Fork 91
WIP for Support Pillow 11 and Python up to 3.13 #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@@ -1,20 +0,0 @@ | |||
# Minimal makefile for Sphinx documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No longer needed, see the top-level Makefile now and make docs
@@ -0,0 +1,47 @@ | |||
.PHONY: all install nopyc clean test docs local |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quality of life improvements for you and anyone else trying to develop on this. Simply run make test
and your dev env will be provisioned and tests run. make local
will install the built version of the library in to your local pip
cache. make docs
, well, docs :).
@@ -1,35 +0,0 @@ | |||
@ECHO OFF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No longer needed, see the top-level Makefile now and make docs
.
The funny part is that they've changed it in a way that it's no longer a captcha. You just need to make a request by passing the values provided in the rendered form. |
# a list of builtin themes. | ||
|
||
html_theme = "sphinx_rtd_theme" | ||
html_theme_path = [sphinx_rtd_theme.get_html_theme_path()] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed anymore with latest version of Sphinx
# | ||
# This is also used if you do content translation via gettext catalogs. | ||
# Usually you set "language" from the command line for these cases. | ||
language = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed with latest version of Sphinx
Via the URL used in validation in this library, yes. But they do still trigger this version of Captcha in some cases, I'm just sure how to fetch it anymore for validation purposes, like this library used to do—effectively, the URL they used to use now just shows a blank image—I'm guessing we need to identify a header to pass in to trigger a "real" Captcha to load now. It's also possible they're going to fully move away from OCR-style Captchas fully in favor of their WAF Captcha as some point, at which point this library won't be useful anymore. Until they keep throwing both at people though, I'm hoping the dev will work with the community and continue to support it. |
They are already using a Cloudflare approach, but not in an aggressive way. They return 403 responses without showing any captcha. In my experience, every time the old-school captcha page was triggered, it is missing the captcha image. I have had about 100k responses like this until I fix the issue. |
Indeed, if you step through the tests on this branch, you'll see that the initial response from What do you mean by "until I fix the issue"—are you saying you've found a workaround solution that you could share, or are you just saying your projects are in the same place as this one, stuck until a workaround is found (or perhaps we just need to abandon this path altogether, if Amazon truly is fully eliminating this type of Captcha from their auth flow). |
I have already mentioned the solution (maybe too implicitly). There is a form field in the new page |
Oh I understand now, yah. Very simple ... and silly. This definitely feels like a step in their progression toward them just removing this type of simple Captcha altogether, so we'll see what they do in the future. Thanks! |
This is a WIP PR, but I'm opening to highlight that this library does still work with
pillow
11+ (which would allow many dependencies, like my own, to add support for Python up to 3.13 if it was re-released this way). The main issue is, the build itself is old and broken, so validating this new version in the previous, automated way is not working.I've made changes to fix the build and test runtime. They fail due to integration issues though, it appears Amazon has changed how you trigger a Captcha, and thus running the battery of accuracy tests does not find a Captcha to validate. I think I'm close to a solution to this, but also am exploring this area of their site for the first time, so thought while I worked toward the solution, I'd open this PR in case anything jumps out as obvious to you from when you were initially implementing these accuracy tests.
Hope this gives us some good direction to go and eventually be able to release a new version to support non-EOL versions of Python. Thanks!