feat: add referer to visits model #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
a-chacon
force-pushed
the
18-add-referrer-information
branch
2 times, most recently
from
7643ca4 to
9fa9a77
Compare
johannesschobel
approved these changes
May 8, 2025
| IpCrawlerJob.perform_later(visit) | ||
| visit | ||
| end | ||
| return false if skip_bot_visit? |
There was a problem hiding this comment.
I did like the earlier version better, having 3 method-calls is quite cumbersome in this case, i guess.
cant we just do
return false if skip_bot_visit?
visit = Visit.create(...)
IpCrawlerJob.perform_later(visit)
return visiti guess, that would be easier to read (i.e., not that many functions).
a-chacon
force-pushed
the
18-add-referrer-information
branch
from
9fa9a77 to
770a5b3
Compare
a-chacon
force-pushed
the
18-add-referrer-information
branch
from
770a5b3 to
a2759c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.