Update sha256example.html #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey! Came across your project and just wanted to say thanks and let you know how valuable the work you are doing is! Quick note: Today I was reading the SHA256 example on your website and I believe I may have come across a little error in the explanation. "Peggy wants to prove that she knows a preimage for a digest chosen by Victor, without revealing what the preimage is" My first intuition after reading this, given this phrasing, is that such a statement is not even really feasible. The setting as is basically forces Alice to perform a (second) preimage attack and find a preimage, or assumes that Victor knows a list of digests controlled by Alice. The first one is basically impossible, and the second is not mentioned in the text. I know that explaining this type of thing is always extremely hard and I may be overcomplicating my take of this writeup, but just wanted to leave a comment regardless. PS: This pull request basically contains what I would consider to be a more cryptographically correct phrasing, but do not feel like this is what an ideal correction would look like.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! Came across your project and just wanted to say thanks and let you know how valuable the work you are doing is!
Quick note: Today I was reading the SHA256 example on your website and I believe I may have come across a little error in the explanation.
"Peggy wants to prove that she knows a preimage for a digest chosen by Victor, without revealing what the preimage is"
My first intuition after reading this, given this phrasing, is that such a statement is not even really feasible. The setting as is basically implies that Alice must perform a (second) preimage attack, or assumes that Victor knows a list of digests controlled by Alice. The first one is basically impossible, and the second is not mentioned in the text.
I know that explaining this type of thing is always extremely hard and I may be overcomplicating my take of this writeup, but just wanted to leave a comment regardless.
PS: This pull request basically contains what I would consider to be a more cryptographically correct phrasing, but do not feel like this is what an ideal correction would look like.