-
Notifications
You must be signed in to change notification settings - Fork 8
chore: Wheels for MacOS and ARM Linux #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Python 3.8 + MacOS arm64 requires special handling https://cibuildwheel.pypa.io/en/stable/faq/#macos-building-cpython-38-wheels-on-arm64
Hi @pgarrison - I will check why I cannot approve this with my account ... (sorry for the delay) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved from sec eng considerations w/ recommendation to make openssl lib and version more transparent to ensure consistency and try to dial down versions used in shipped packages to properly audit
All lint errors should now be resolved. My contributions are covered under the corporate CLA signed by the Allen Institute. |
@pgarrison and @DaveyJonesBitPail what is still missing to merge this and make a new release for pylibCZIrw? |
from the security standpoint there are no further requirements. Looking at the failing linux build it looks like a vcpkg-related CI issue. VCPKG_INSTALLATION_ROOT ought to be set appropriately OOB however.... |
(I think I fixed the install and tested on my fork; waiting on CI to re-run) |
Edit: It appears the canceled jobs are due to the windows-2019 runner being removed. Getting CI to run now depends on my PR #84. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #85 +/- ##
=======================================
Coverage 96.56% 96.56%
=======================================
Files 1 1
Lines 379 379
Branches 51 51
=======================================
Hits 366 366
Misses 7 7
Partials 6 6
🚀 New features to boost your workflow:
|
Notes on current build errors:
|
Fixes #57
Fixes #82
Fixes bioio-devs/bioio-czi#51
Context
pylibrczirw
does not provide wheels for MacOS or ARM Linux. In some installation contexts, build dependencies like cmake are unavailable, which makespylibczirw
unusable. Specifically, this is an issue downstream for bioio-czi.Changes
Added 3 new build artifacts: x86-64 MacOS, ARM64 MacOS, and ARM64 Linux, with MacOS-specific build logic in setup.py.
Testing
I only tested the ARM64 MacOS wheel, since that's the hardware I have. I was able to install the wheel and
import pylibCZIrw
.Review notes
I strongly recommend also merging my PR #84 so that CI continues to work past the end of the month.