fix: add pyproject.toml to specify build requirements #74
Conversation
|
Feel free to also use this patch I drafted to migrate more thoroughly to pyproject.toml |
@pgarrison thanks! do you know if this will fix the issue with pip install needing manual install of packaging on a clean dockerised environment |
I haven't tested that, but my pyproject.toml includes everything yours does. |
.github/actions/steps_psr/action.yml
Outdated
| set -x | ||
| pip install . > /dev/null | ||
| echo "Reading version from setup.py" | ||
| ver=$(grep -Po '^VERSION\s*=\s*["'\'']\K[^"'\''"]+' setup.py | head -1) |
There was a problem hiding this comment.
This may require setting the locale or using sed with a different regex formulation
pyproject.toml
Outdated
| @@ -0,0 +1,3 @@ | |||
| [build-system] | |||
| requires = ["setuptools>=42", "wheel", "packaging"] | |||
There was a problem hiding this comment.
setuptools also has a relatively niche CVE for version before 70.0.0 : https://avd.aquasec.com/nvd/2024/cve-2024-6345/
As far as I can tell this is not really relevant for usage in this repo but something to note.
|
I had to abondon this pr as i made changes to main in my fork, and it wasnt updated for a while. I suggest to make a bug and pr for this fix, if needed |
3 participants
fix: add pyproject.toml to specify build requirements, as this pip install doesnt work on clean dockerised environment
[x ] I followed the How to structure your PR.
[x] Based on Commit Parsing: In case a new major release will be created (because the body or footer begins with 'BREAKING CHANGE:'), I created a new Jupyter notebook with a matching version.
[x] Based on Commit Parsing: In case a new minor/patch release will be created (because PR title begins with 'feat'/('fix' or 'perf')), I optionally created a new Jupyter notebook with a matching version.
[ ] In case of API changes, I updated API.md.
Fixes
add pyproject.toml to specify build requirements, as this pip install doesnt work on clean dockerised environment