Skip to content

Conversation

DaveyJonesBitPail
Copy link
Contributor

@DaveyJonesBitPail DaveyJonesBitPail commented Aug 6, 2025

Description

  • Define vcpkg manifest and add optional bootstrapping.
  • Bootstrap option is on by default
  • Align vcpkg with baseline expected in manifest
  • Cache vcpkg and package installs across OS and vcpkg.json hash
  • Consume pugixml w/ header-only def if bootstrapped
  • Bump version

Additional notes

  • We now have another version defined in the vcpkg.json. This should align with the version defined in CMakeLists.txt. There ought to be a graceful way to have a single source of truth.
  • The dependencies resolved via vcpkg are not pinned to specific versions. Thankfully this worked so far, however we should consider using a vcpkg lock file or being explicit with overrides in the manifest
  • The build scripts could use a cleanup/restructuring. Adding the lots of if conditions does not make for easily readable and robust build scripts....

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Describe the tests that you ran to verify your changes.
Provide instructions to reproduce.

Checklist:

  • I followed the Contributing Guidelines.
  • I did a self-review.
  • I commented my code, particularly in hard-to-understand areas.
  • I updated the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@DaveyJonesBitPail DaveyJonesBitPail added the cla Contributor License Agreement sent to Admin label Aug 6, 2025
@DaveyJonesBitPail DaveyJonesBitPail requested review from m-aXimilian and ptahmose and removed request for m-aXimilian August 6, 2025 19:45
@ptahmose
Copy link
Contributor

ptahmose commented Aug 6, 2025

This is damn cool - thanks!

@DaveyJonesBitPail DaveyJonesBitPail marked this pull request as ready for review September 11, 2025 09:11
Copy link
Contributor

@m-aXimilian m-aXimilian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing I am not directly convinced is that inc_libCZI.h is now inc_libCZI.h.in. Other than that it looks good to me despite the missing documentation update in version-history.md.
Btw: I think we should increment to 0.6.5 judging from the version-history file. (I failed to increment the version in the root CMakeLists.txt in the last commit...sorry!)

@DaveyJonesBitPail
Copy link
Contributor Author

The only thing I am not directly convinced is that inc_libCZI.h is now inc_libCZI.h.in. Other than that it looks good to me despite the missing documentation update in version-history.md. Btw: I think we should increment to 0.6.5 judging from the version-history file. (I failed to increment the version in the root CMakeLists.txt in the last commit...sorry!)

Hmmm, that's a fair point. It would make things a good bit cleaner. Thanks!

m-aXimilian
m-aXimilian previously approved these changes Sep 24, 2025
Copy link
Contributor

@m-aXimilian m-aXimilian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

m-aXimilian
m-aXimilian previously approved these changes Sep 24, 2025
@DaveyJonesBitPail DaveyJonesBitPail merged commit 7b6f245 into main Sep 24, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla Contributor License Agreement sent to Admin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants