-
Notifications
You must be signed in to change notification settings - Fork 4
Add optional vcpkg bootstrapping for dependencies #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 2b64dc7.
This is damn cool - thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only thing I am not directly convinced is that inc_libCZI.h
is now inc_libCZI.h.in
. Other than that it looks good to me despite the missing documentation update in version-history.md.
Btw: I think we should increment to 0.6.5
judging from the version-history file. (I failed to increment the version in the root CMakeLists.txt in the last commit...sorry!)
Hmmm, that's a fair point. It would make things a good bit cleaner. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
6fcc4ef
to
8d0e4a5
Compare
Description
Additional notes
Fixes # (issue)
Type of change
How Has This Been Tested?
Describe the tests that you ran to verify your changes.
Provide instructions to reproduce.
Checklist: