Skip to content

Conversation

DaveyJonesBitPail
Copy link
Contributor

@DaveyJonesBitPail DaveyJonesBitPail commented Sep 3, 2024

Description

Add third party license attribution notice text to allow for binary distribution

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

No code changes so no text is necessary

Checklist:

  • I followed the Contributing Guidelines.
  • I did a self-review.
  • I commented my code, particularly in hard-to-understand areas.
  • I updated the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@DaveyJonesBitPail DaveyJonesBitPail added the cla Contributor License Agreement sent to Admin label Sep 3, 2024
Copy link
Contributor

@m-aXimilian m-aXimilian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add the change in the version history as well? 0.5.1?
https://github.com/ZEISS/czicheck/blob/main/documentation/version-history.md

@DaveyJonesBitPail
Copy link
Contributor Author

Maybe add the change in the version history as well? 0.5.1? https://github.com/ZEISS/czicheck/blob/main/documentation/version-history.md

Thanks for the reminder :) We should leverage Github releases at some point as well....

@DaveyJonesBitPail DaveyJonesBitPail force-pushed the add_third_party_license_text branch 2 times, most recently from 76dc1f4 to 8326b1f Compare September 3, 2024 15:45
m-aXimilian
m-aXimilian previously approved these changes Sep 3, 2024
@DaveyJonesBitPail DaveyJonesBitPail force-pushed the add_third_party_license_text branch 9 times, most recently from f2e8371 to 33805fe Compare September 3, 2024 21:07
@DaveyJonesBitPail DaveyJonesBitPail force-pushed the add_third_party_license_text branch from 33805fe to 593e9d9 Compare September 3, 2024 21:17
@DaveyJonesBitPail DaveyJonesBitPail force-pushed the add_third_party_license_text branch 3 times, most recently from ddf0afa to 5faeb78 Compare September 3, 2024 21:40
@DaveyJonesBitPail DaveyJonesBitPail force-pushed the add_third_party_license_text branch from 5faeb78 to 684284b Compare September 3, 2024 21:45
@DaveyJonesBitPail DaveyJonesBitPail force-pushed the add_third_party_license_text branch 4 times, most recently from 6c9378f to 8ad18e4 Compare September 4, 2024 07:12
@DaveyJonesBitPail DaveyJonesBitPail force-pushed the add_third_party_license_text branch from 8ad18e4 to fbb427c Compare September 4, 2024 07:17
@DaveyJonesBitPail DaveyJonesBitPail marked this pull request as ready for review September 4, 2024 07:47
@DaveyJonesBitPail DaveyJonesBitPail requested a review from a team September 4, 2024 07:47
ptahmose
ptahmose previously approved these changes Sep 4, 2024
m-aXimilian
m-aXimilian previously approved these changes Sep 4, 2024
Copy link
Contributor

@m-aXimilian m-aXimilian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

ptahmose
ptahmose previously approved these changes Sep 4, 2024
Copy link
Contributor

@ptahmose ptahmose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@DaveyJonesBitPail DaveyJonesBitPail merged commit 44e0bc3 into main Sep 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla Contributor License Agreement sent to Admin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants