Add prf extension #413
Merged
Add prf extension #413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes test errors like the following: ``` Exception com.fasterxml.jackson.databind.exc.InvalidDefinitionException: Cannot find a (Map) Key deserializer for type [simple type, class com.yubico.webauthn.data.PublicKeyCredentialDescriptor] [in thread "Test worker"] ``` which also by extension means even if we fix the deserializer resolution, `JsonIoSpec` will fail with `PublicKeyCredentialDescriptor` as keys because input/output JSON will not be identical after deserializing from just the credential ID. Therefore let's change the map key type to `ByteArray`. We can keep the `PublicKeyCredentialDescriptor` key type in setters, but transform to `ByteArray` keys during construction of the `PrfAuthenticationInput` value.
The factory functions on PrfRegistrationInput and PrfAuthenticationInput should be enough.
Test Results2 267 tests 2 259 ✅ 1m 6s ⏱️ Results for commit 538e565. ♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.