Offer enums as completion items in expressions #329
Annotations
1 error and 10 warnings
|
build
Process completed with exit code 1.
|
|
build:
YarnSpinner/CRC32.cs#L95
'string.Replace(string, string)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'Yarn.Utility.CRC32.GetChecksumString(string)' with a call to 'string.Replace(string, string, System.StringComparison)' for clarity of intent. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1307)
|
|
build:
YarnSpinner/NumberPlurals.cs#L1941
'string.IndexOf(char)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'CLDRPlurals.NumberHelpers.VisibleFractionalDigits(double, bool)' with a call to 'string.IndexOf(char, System.StringComparison)' for clarity of intent. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1307)
|
|
build:
YarnSpinner/NumberPlurals.cs#L1930
'string.IndexOf(char)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'CLDRPlurals.NumberHelpers.FractionalValue(double)' with a call to 'string.IndexOf(char, System.StringComparison)' for clarity of intent. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1307)
|
|
build:
YarnSpinner/YarnSpinner.Markup/LineParser.cs#L1590
'string.Replace(string, string)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'Yarn.Markup.LineParser.ExpandSubstitutions(string, System.Collections.Generic.IList<string>)' with a call to 'string.Replace(string, string, System.StringComparison)' for clarity of intent. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1307)
|
|
build:
YarnSpinner/YarnSpinner.Markup/LineParser.cs#L993
'string.Replace(string, string)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'Yarn.Markup.LineParser.BuildMarkupTreeFromTokens(System.Collections.Generic.List<Yarn.Markup.LineParser.LexerToken>, string)' with a call to 'string.Replace(string, string, System.StringComparison)' for clarity of intent. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1307)
|
|
build:
YarnSpinner/YarnSpinner.Markup/LineParser.cs#L990
Use 'string.EndsWith(char)' instead of 'string.EndsWith(string)' when you have a string with a single char (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1865)
|
|
build:
YarnSpinner/YarnSpinner.Markup/LineParser.cs#L990
Use 'string.StartsWith(char)' instead of 'string.StartsWith(string)' when you have a string with a single char (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1865)
|
|
build:
YarnSpinner/YarnSpinner.Markup/LineParser.cs#L821
'string.Replace(string, string)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'Yarn.Markup.LineParser.WalkTree(Yarn.Markup.LineParser.MarkupTreeNode, System.Text.StringBuilder, System.Collections.Generic.List<Yarn.Markup.MarkupAttribute>, string, System.Collections.Generic.List<Yarn.Markup.LineParser.MarkupDiagnostic>, int)' with a call to 'string.Replace(string, string, System.StringComparison)' for clarity of intent. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1307)
|
|
build:
YarnSpinner/YarnSpinner.Markup/LineParser.cs#L820
'string.Replace(string, string)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'Yarn.Markup.LineParser.WalkTree(Yarn.Markup.LineParser.MarkupTreeNode, System.Text.StringBuilder, System.Collections.Generic.List<Yarn.Markup.MarkupAttribute>, string, System.Collections.Generic.List<Yarn.Markup.LineParser.MarkupDiagnostic>, int)' with a call to 'string.Replace(string, string, System.StringComparison)' for clarity of intent. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1307)
|
|
build:
YarnSpinner/Program.cs#L266
Member 'OnConstruction' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)
|