Skip to content

Conversation

@Person-93
Copy link
Contributor

@Person-93 Person-93 commented Oct 5, 2025

The demo depends on a crate that hasn't been updated.

@Person-93
Copy link
Contributor Author

Two of the checks failed.

Building the demo for the web will obviously have to wait until the demo is re-added.

As for the failing test with bevy, it looks like the job on github actions did not complete. The log is cut off because it ran out of space.

@janhohenheim
Copy link
Collaborator

janhohenheim commented Oct 7, 2025

@FraserLee mind hitting cargo publish? ;)
Edit: oh nvm the RC is published. Why do we need to comment out the demo then? bevy_sprite_3d should pull in bevy 0.17 via cargo update as it's semver compatible. Unless I'm misunderstanding which crate you're referencing :)

@Person-93
Copy link
Contributor Author

Why do we need to comment out the demo then? bevy_sprite_3d should pull in bevy 0.17 via cargo update as it's semver compatible. Unless I'm misunderstanding which crate you're referencing :)

Release candidates are not semver compatible with actual releases. https://semver.org/#spec-item-9

@janhohenheim
Copy link
Collaborator

janhohenheim commented Oct 7, 2025

You're absolutely right, but Cargo's semver is different from the standard semver :) Try cargo update and run cargo tree -i bevy --depth=1 to verify:
image

NB: standard semver also says that 0.1.0 and 0.1.1 are not compatible (because all 0.x.y releases are incompatible), and Cargo happily treats the minor bump as compatible

@janhohenheim janhohenheim marked this pull request as ready for review October 7, 2025 14:34
@janhohenheim
Copy link
Collaborator

janhohenheim commented Oct 7, 2025

Merging this now, but before publishing I'd like to also rename our Messages so they don't have the Event suffix:

@janhohenheim janhohenheim enabled auto-merge October 7, 2025 14:36
@janhohenheim janhohenheim merged commit 99b9fdd into YarnSpinnerTool:main Oct 7, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants