tweaks to instrumentation (logs, traces and metrics) #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces instrumentation updates to enhance logging, tracing, and metrics across various components. Key changes include adding a logger to the CompletionRetrier, updating activity recording with error statuses and exception details in several services, and integrating an UpDownCounter for pending retry metrics.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Core/ServiceCollectionExtensions.cs | Adds a logger dependency to the CompletionRetrier factory method. |
| src/Core/Polling/PollingProducer.cs | Enhances error logging with activity status updates in a catch block. |
| src/Core/Polling/CompletionRetrier.cs | Modifies the retry logic details, updates metrics, and adds logger usage. |
| src/Core/OpenTelemetry/CompletionRetrierMetrics.cs | Introduces an UpDownCounter for tracking pending retry messages. |
| src/Core/OpenTelemetry/ActivityShared.cs | Adds an extension method to record exception details on activities. |
| src/Core/CleanUp/CleanUpBackgroundService.cs | Updates the using pattern and enriches error telemetry in clean-up tasks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.