Introduce mechanism to collect and retry completing successfully produced messages #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a mechanism to collect and retry completing successfully produced messages in order to minimize duplicates that could occur when the message completion (e.g. persistence) fails due to transient errors. Key changes include:
- Renaming of helper classes and updating references from BatchFetcherTestHelpers to TestHelpers in tests for both PostgreSQL and MySQL providers.
- Introduction of a new BatchCompleter along with an IBatchCompleteRetrier interface along with corresponding tests and dependency injection registrations for PostgreSQL, MySQL, and MongoDB providers.
- Updates to producer and background service implementations to utilize the new completion retry mechanism and associated metrics.
Reviewed Changes
Copilot reviewed 38 out of 38 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/**/*.cs | Renames and updates helper class references for consistency. |
| src//Polling/*.cs and src//ConfigurationExtensions.cs | Integrates the BatchCompleter and IBatchCompleteRetrier in providers’ DI setup. |
| src/Core/Polling/PollingProducer.cs & PollingBackgroundService.cs | Modifies producer and background service to use the new retry mechanism. |
| docs/building-a-provider/*.md | Updates documentation to mention the retry mechanism and IBatchCompleteRetrier. |
Comments suppressed due to low confidence (1)
docs/building-a-provider/push.md:7
- [nitpick] Consider removing the informal emoji to maintain a professional tone in the documentation.
🚧 coming soon (maybe 😂)
This was referenced Jun 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a mechanism to collect and retry persisting the information that some messages were successfully produced to the application's message broker.
The idea is o minimize the occurrence of duplicated message production. This could happen if after producing the messages, something goes wrong when connecting to the database.
This implementation is a best effort one, in that the produced messages are kept in memory to retry completion. If the process restarts or if there's a concurrent process, messages will still be produced again.
Closes #41