Skip to content

#141, 142 - 쪽지 답장 온보딩 시트 조회 API를 구현합니다. #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025

Conversation

kpeel5839
Copy link
Contributor

1. 🔗 관련 이슈

closes #141
closes #142

2. 📄 구현한 내용 또는 수정한 내용

  • 답장하기 기능 온보딩 시트 구현했습니다.
  • 조회처리도 되게끔 했습니다.

3. ✅ 배포 Checklist

  • 본인을 Assign 해주세요.

@kpeel5839 kpeel5839 requested a review from Copilot May 6, 2025 11:48
@kpeel5839 kpeel5839 self-assigned this May 6, 2025
@kpeel5839 kpeel5839 added 🌱기능🌱 새로운 기능을 추가해요 ! 🏋️매튜🏋️ 24기 김재연 labels May 6, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements the answer message onboarding sheet API and extends the onboarding functionality to support a new ANSWER_MESSAGE category.

  • Added an onboarding explanation component for reply messages with customized texts, images, and buttons.
  • Extended the onboarding category enum, bottom sheet component, and related DTOs and service logic to support ANSWER_MESSAGE onboarding.
  • Updated the viewed onboarding sheet model and message service to accommodate the new onboarding type.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
domain/src/main/kotlin/com/wespot/view/OnBoardingExplanationComponent.kt Added a new function to create an explanation component for answer messages.
domain/src/main/kotlin/com/wespot/view/OnBoardingCategory.kt Introduced the ANSWER_MESSAGE enum value with a redundant null check on valueOf.
domain/src/main/kotlin/com/wespot/view/OnBoardingBottomSheetComponent.kt Added support for ANSWER_MESSAGE by creating a new bottom sheet type function.
domain/src/main/kotlin/com/wespot/common/ViewedOnBoardingSheet.kt Added a constant and logic for ANSWER_MESSAGE onboarding state.
core/src/main/kotlin/com/wespot/message/service/v2/GetMessageV2Service.kt Removed commented-out code to use finder functions directly.
core/src/main/kotlin/com/wespot/common/service/view/OnBoardingService.kt Updated page response composition and annotated the method as read-only transactional.
core/src/main/kotlin/com/wespot/common/dto/OnBoardingResponse.kt Overloaded the fromFirstPage and fromSecondPage functions to handle the new input values.
core/src/main/kotlin/com/wespot/common/dto/OnBoardingComponentRequest.kt Added the ANSWER_MESSAGE member to the request enum.
Comments suppressed due to low confidence (1)

domain/src/main/kotlin/com/wespot/view/OnBoardingCategory.kt:20

  • Since the enum's valueOf method throws an exception when no matching constant is found, this null check is redundant. Consider removing it to simplify the logic.
if (Objects.isNull(findValue)) {

fun createAnswerMessageComponent(): OnBoardingExplanationComponent {
return OnBoardingExplanationComponent(
textComponent = TextComponent.of(
RichText.of("답장하기에 대해 알려드릴게요", "#FFF7F7F8", 20, "Center", "Bold"),
Copy link
Preview

Copilot AI May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider extracting the hard-coded color value "#FFF7F7F8" (and similar literals) into a constant to improve maintainability and ease future updates.

Suggested change
RichText.of("답장하기에 대해 알려드릴게요", "#FFF7F7F8", 20, "Center", "Bold"),
RichText.of("답장하기에 대해 알려드릴게요", COLOR_TEXT_PRIMARY, 20, "Center", "Bold"),

Copilot uses AI. Check for mistakes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope i don't want

@kpeel5839 kpeel5839 merged commit c7da0ca into develop May 6, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱기능🌱 새로운 기능을 추가해요 ! 🏋️매튜🏋️ 24기 김재연
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature]: 쪽지 온보딩 조회 처리 [feature]: 답장하기 온보딩 시트를 구현합니다.
1 participant