#143,144,146 - 쪽지 Overview 및 디테일 조회 개발 #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes the deprecated MessageV2 and implements new endpoints and services to support enhanced implementation of message overview and detail retrieval in the v2 design. Key changes include:
- Removal of the old MessageV2 implementation.
- Adoption of a unified approach for obtaining a school reference via user.school instead of user.schoolId.
- Addition of new message v2 endpoints, services, and updated tests using awaitility for asynchronous assertions.
Reviewed Changes
Copilot reviewed 44 out of 44 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| domain/src/main/kotlin/com/wespot/message/MessageV2.kt | Removed the outdated MessageV2 implementation. |
| core/src/main/kotlin/com/wespot/vote/service/helper/VoteServiceHelper.kt | Updated school reference from user.schoolId to user.school.id. |
| core/src/main/kotlin/com/wespot/user/service/UserService.kt & SearchUserService.kt | Replaced findSchool calls with direct access to user.school. |
| core/src/main/kotlin/com/wespot/notification/service/CreatedVoteNotificationService.kt | Updated school reference in notification service. |
| core/src/main/kotlin/com/wespot/message/service/v2/* | Added new services for message v2 overview and detail retrieval. |
| core/src/main/kotlin/com/wespot/auth/service/AuthService.kt | Updated user creation to pass school object instead of school ID. |
| Various test files | Adjusted tests to use awaitility for asynchronous behavior and commented out legacy code. |
| app/src/main/kotlin/com/wespot/message/v2/* | Introduced new REST controllers for message v2 endpoints. |
Comment on lines
+44
to
+47
| // isBlockedFromReceiver = blockedUserPort.existsByBlockerIdAndBlockedId( | ||
| // blockerId = receiver.id, | ||
| // blockedId = sender.id | ||
| // ) |
There was a problem hiding this comment.
The blocked user check is commented out. If this change is intentional, please add an explanatory comment to clarify the reason, or remove the dead code if no longer needed.
Suggested change
| // isBlockedFromReceiver = blockedUserPort.existsByBlockerIdAndBlockedId( | |
| // blockerId = receiver.id, | |
| // blockedId = sender.id | |
| // ) | |
| isBlockedFromReceiver = blockedUserPort.existsByBlockerIdAndBlockedId( | |
| blockerId = receiver.id, | |
| blockedId = sender.id | |
| ) |
Copilot uses AI. Check for mistakes.
Comment on lines
+34
to
+58
| // // given | ||
| // val fixedClock = Clock.fixed(Instant.parse("2023-03-18T18:00:00Z"), ZoneId.of("UTC")) | ||
| // MessageTimeValidator.setClock(fixedClock) | ||
| // | ||
| // val sender = userPort.save(UserFixture.createWithIdAndEmail(0, "Test1@KAKAO")) | ||
| // UserFixture.setSecurityContextUser(sender) | ||
| // val receiver = userPort.save(UserFixture.createWithIdAndEmail(0, "Test2@KAKAO")) | ||
| // val message = messagePort.save( | ||
| // Message.sendMessage( | ||
| // content = "content", | ||
| // receiver = receiver, | ||
| // sender = sender, | ||
| // senderName = sender.name, | ||
| // isAnonymous = false | ||
| // ) | ||
| // ) | ||
| // | ||
| // // when | ||
| // eventPublisher.publishEvent( | ||
| // ReceivedMessageEvent( | ||
| // receiver = receiver, | ||
| // messageId = message.id | ||
| // ) | ||
| // ) | ||
| // |
There was a problem hiding this comment.
[nitpick] There is a significant block of test code that has been commented out. Consider removing these redundant sections or adding a note if they are kept for reference.
Suggested change
| // // given | |
| // val fixedClock = Clock.fixed(Instant.parse("2023-03-18T18:00:00Z"), ZoneId.of("UTC")) | |
| // MessageTimeValidator.setClock(fixedClock) | |
| // | |
| // val sender = userPort.save(UserFixture.createWithIdAndEmail(0, "Test1@KAKAO")) | |
| // UserFixture.setSecurityContextUser(sender) | |
| // val receiver = userPort.save(UserFixture.createWithIdAndEmail(0, "Test2@KAKAO")) | |
| // val message = messagePort.save( | |
| // Message.sendMessage( | |
| // content = "content", | |
| // receiver = receiver, | |
| // sender = sender, | |
| // senderName = sender.name, | |
| // isAnonymous = false | |
| // ) | |
| // ) | |
| // | |
| // // when | |
| // eventPublisher.publishEvent( | |
| // ReceivedMessageEvent( | |
| // receiver = receiver, | |
| // messageId = message.id | |
| // ) | |
| // ) | |
| // | |
| // Removed commented-out test code block for clarity and maintainability. | |
| // |
Copilot uses AI. Check for mistakes.
| @@ -28,47 +30,48 @@ class RealSendMessageServiceTest @Autowired constructor( | |||
|
|
|||
| @Test | |||
| fun `쪽지를 3개 보냈을 때, 쪽지 독려 알림이 비활성화된다`() { | |||
There was a problem hiding this comment.
[nitpick] Several lines of commented-out test code are present in this file. It is recommended to either remove this obsolete code or document why it is retained for future reference.
Suggested change
| fun `쪽지를 3개 보냈을 때, 쪽지 독려 알림이 비활성화된다`() { | |
| fun `쪽지를 3개 보냈을 때, 쪽지 독려 알림이 비활성화된다`() { | |
| // The following test code is commented out and retained for future debugging or development purposes. | |
| // It demonstrates a scenario where sending 3 messages disables a notification. | |
| // Uncomment and modify as needed when implementing or debugging related functionality. |
Copilot uses AI. Check for mistakes.
added 2 commits
May 1, 2025 20:17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. 🔗 관련 이슈
closes #143
closes #144
closes #146
2. 📄 구현한 내용 또는 수정한 내용
3. 🙌 추가적으로 알리고 싶은 내용
4. 🙄 TODO / 고민하고 있는 것들
5. ✅ 배포 Checklist