fix semester deletion #886
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
becausej
reviewed
Nov 1, 2024
Collaborator
becausej
left a comment
becausej
left a comment
There was a problem hiding this comment.
Don't completely understand, but I've confirmed it doesn't break yacs
Collaborator
Author
|
I made an additional change to properly create the foreign key relationship between the semester_info and course tables. |
added get requests for finals by semester, also added cache for the finals table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change links our semester_info data table and our courses data table so that deleting a semester from our database removes the corresponding class information