Clean up mpt_holders reference documentation + add Try It #3104
+117
−102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maria-robobug
force-pushed
the
mpt-holders-doc-cleanup
branch
from
1e7ccef to
8373039
Compare
maria-robobug
changed the title
maria-robobug
force-pushed
the
mpt-holders-doc-cleanup
branch
from
8373039 to
bedda2a
Compare
mDuo13
approved these changes
May 7, 2025
There was a problem hiding this comment.
LGTM.
Having the examples on Devnet is best for now—since MPTs are not even enabled on Mainnet yet—but eventually it would be preferable to switch the examples to use Mainnet so that we don't have to re-create the same data every time there's a Devnet reset. Devnet resets are somewhat irregular but can be as often as multiple times per year, whereas on Mainnet we can generally create sample data once and leave it there forever. So that's a task to note for later, but it can't be done until MPT is enabled and there's no need to do anything until the next Devnet reset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up API reference based on issues raised in mpt_holders documentation needs some cleanup #3017
Also added support for
devnet-clioandtestnet-cliofor the "TryIt" component. This wasn't fully wired up previously it seems.Preview: https://xrpl-dev-portal--mpt-holders-doc-cleanup.preview.redocly.app/docs/references/http-websocket-apis/public-api-methods/clio-methods/mpt_holders
The "Try it" example defaults to a Devnet example request, as I've created an MPT in that environment. I don't have one for Mainnet, but do let me know if we absolutely require this to be Mainnet.