Code Quality: fix browser deprecation warning #762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
force-pushed
the
fix/browser-deprecated-warning
branch
2 times, most recently
from
b37d0bc to
7bf0332
Compare
t-hamano
force-pushed
the
fix/browser-deprecated-warning
branch
from
7bf0332 to
e58be19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suppresses browser warning logs that occur in WP 6.8. I made changes based on the field guide from the following three perspectives:
1. Updates to user-interface components in WordPress 6.8 - Default 36px sizes are now deprecated
Add
__next40pxDefaultSizeto the form component that is causing the deprecation warning. This means the height of the component will change from 36px to 40px. Example:2. Updates to user-interface components in WordPress 6.8 - Stabilized Navigator
Use
Navigatior.BackButtoninstead of__experimentalNavigatorToParentButton. For backward compatibility, check whetherNavigatior.BackButtonis undefined, and if it is, use the conventional component.3. Data: A helpful performance warning for developers in the ‘useSelect’ hook
Refactored one of the
useSelecthooks, which is not used properly. The useSelect Hook itself should not be asynchronous.